![]() ![]() The only data being stored in the state is data necessary for rendering and nothing else.The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone.All props are defined accurately and each prop has a /** comment above it */.A similar component doesn't exist in the codebase.If a new component is created I verified that:.I verified that if a function's arguments changed that all usages have also been updated correctly.in CONST.js or at the top of the file that uses the constant) are defined as such I verified any variables that can be defined as constants (ie.I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests).if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) I tested other components that can be impacted by my changes (i.e.I followed the guidelines as stated in the Review Guidelines.If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers.I verified the JSDocs style guidelines (in STYLE.md) were followed.All platform-specific files are named for the platform the code supports as outlined in the README. All non-platform specific files are named after what they export and are not named "index.js". I verified proper file naming conventions were followed for any new files or renamed files.I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods.If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer.I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method.I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.I verified that comments were added to code that is not self explanatory.I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.I followed proper code patterns (see Reviewing the code).I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed).I ran the tests on all platforms & verified they passed on:.I included screenshots or videos for tests on all platforms.long loading states that impact usability). I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g.verify the default avatar icon is displayed if app is offline) I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e.verify an input displays the correct error message if the entered data is not correct) I added steps to cover failure scenarios (i.e.I added steps for Staging and/or Production testing in the QA steps section.I added steps for the expected offline behavior in the Offline steps section.I added steps for local testing in the Tests section.I wrote clear testing steps that cover the changes made in this PR.I linked the correct issue in the # Fixed Issues section above. ![]() Note that both Get Started links will direct to NewDot.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |